Add support to write DIDs from command line #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there, I just wanted to say that I have had a first look and cleaned up the code a bit (branches where uninitialized variables were called etc), but finding the root cause of the error remains 😅 I will have another look! |
|
Update: My current gut feeling says your code is not at fault. It might be caused by a bug in the testing harness, where the Digging into that class and its parents has caused me to make a few double takes so far, I will have to keep looking 😅 Might be threading related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #117. In summary, the testing harness is failing and I need help debugging!