fix(bot): add missing implicit permissions checks (#362)

CarelessInternet · Feb 12, 2024 · db71663 · db71663
1 parent fd9ecf5
commit db71663
Show file tree

Hide file tree

Showing 5 changed files with 175 additions and 63 deletions.
diff --git a/apps/bot/src/commands/thread-ticketing/ticket.ts b/apps/bot/src/commands/thread-ticketing/ticket.ts
@@ -465,7 +465,8 @@ export class ModalInteraction extends Modal.Interaction {
  const logsChannel = await guild.channels.fetch(configuration.ticketThreadsCategories.logsChannelId);
 
  if (!logsChannel?.isTextBased()) return;
- if (!logsChannel.permissionsFor(me).has([PermissionFlagsBits.SendMessages])) return;
+ if (!logsChannel.permissionsFor(me).has([PermissionFlagsBits.ViewChannel, PermissionFlagsBits.SendMessages]))
+ return;
 
  await logsChannel.send({
  embeds: [
@@ -572,7 +573,8 @@ export class ModalInteraction extends Modal.Interaction {
  const logsChannel = await guild.channels.fetch(row.logsChannelId);
 
  if (!logsChannel?.isTextBased()) return;
- if (!logsChannel.permissionsFor(me).has([PermissionFlagsBits.SendMessages])) return;
+ if (!logsChannel.permissionsFor(me).has([PermissionFlagsBits.ViewChannel, PermissionFlagsBits.SendMessages]))
+ return;
 
  void logsChannel.send({
  embeds: [

diff --git a/apps/bot/src/events/guild/GuildMemberAdd.ts b/apps/bot/src/events/guild/GuildMemberAdd.ts
@@ -23,7 +23,7 @@ export default class extends Event.Handler {
 
  if (data.welcomeNewMemberRoles.length > 0) {
  const highestRoleWithManageRoles = me.roles.cache
- .filter((role) => role.permissions.has(PermissionFlagsBits.ManageRoles))
+ .filter((role) => role.permissions.has([PermissionFlagsBits.ManageRoles]))
  .sort((a, b) => b.position - a.position)
  .at(0);
 

diff --git a/apps/website/package.json b/apps/website/package.json
@@ -18,7 +18,7 @@
  "@vercel/analytics": "^1.1.3",
  "class-variance-authority": "^0.7.0",
  "clsx": "^2.1.0",
- "lucide-react": "^0.323.0",
+ "lucide-react": "^0.330.0",
  "next": "14.1.0",
  "next-themes": "^0.2.1",
  "react": "^18.2.0",

diff --git a/packages/eslint-config/package.json b/packages/eslint-config/package.json
@@ -3,8 +3,8 @@
  "private": true,
  "main": "index.cjs",
  "devDependencies": {
- "@typescript-eslint/eslint-plugin": "^6.21.0",
- "@typescript-eslint/parser": "^6.21.0",
+ "@typescript-eslint/eslint-plugin": "^7.0.1",
+ "@typescript-eslint/parser": "^7.0.1",
  "eslint-config-next": "^14.1.0",
  "eslint-config-prettier": "^9.1.0",
  "eslint-config-turbo": "^1.12.3",