Add small note about the (non) use of resource pool regarding databas…

…e connection acquisition.
CardanoSolutions · Feb 27, 2022 · d404ede · d404ede
1 parent 73a653d
commit d404ede
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/Kupo.hs b/src/Kupo.hs
@@ -129,6 +129,11 @@ kupo tr@Tracers{tracerChainSync, tracerHttp, tracerDatabase} = hijackSigTerm *>
             -- HTTP Server
             ( runServer
                 tracerHttp
+                -- NOTE: This should / could probably use a resource pool to
+                -- avoid re-creating a new connection on every requests. This is
+                -- however pretty cheap with SQLite anyway and the HTTP server
+                -- isn't meant to be a public-facing web server serving millions
+                -- of clients.
                 (withDatabase nullTracer ReadOnly lock longestRollback dbFile)
                 serverHost
                 serverPort