Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ConniveAi.java #6780

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update ConniveAi.java #6780

wants to merge 1 commit into from

Conversation

tehdiplomat
Copy link
Contributor

No description provided.

@@ -18,6 +18,11 @@ protected boolean canPlayAI(Player ai, SpellAbility sa) {
return false; // can't draw anything
}

final int num = AbilityUtils.calculateAmount(host, sa.getParamOrDefault("ConniveNum", "1"), sa);
if (num == 0) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this yet. It might break if you need to payX for Connive.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thing that there isn't a PayX right now

But the trigger ones still need to target

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the trigger one can be 0 since its based off combat damage.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also

Whenever you attack, target attacking creature connives X, where X is the number of attacking creatures.

But that can't be 0 either, while targeting

@Agetian
Copy link
Contributor

Agetian commented Jan 20, 2025

It looks like there's a compile-time error of some sort during the tests, can you please check it out?

@tehdiplomat
Copy link
Contributor Author

Yea i know i didnt import. I'll get back to this later in the week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants