Duel commander format

[misha-colbourne]

I've added Duel Commander as a format, but in order to have the tab for it show up in the Deck Editor it needs to be present in the appdata editor.xml. I've edited the forge-gui default version of it, but this needs to be somehow applied to the user's appdata version for it to actually work.

May need the correct way to update a user's editor.xml to include the new tab without requiring users to manually update it?

[misha-colbourne]

@kevlahnota I've added "banned as commander" support for Duel Commander and Tiny Leaders as per your suggestion

[Agetian]

Is any further work needed on this MR?

[tool4ever]

I guess one of us should test it ingame, not sure that's been done yet?

[misha-colbourne]

Done as far as code is concerned, but I still don't know how to update a user's editor.xml to include the new tab for it in the deck builder. I've edited the forge-gui editor.xml but had to manually add the tab to my app data version - any idea how to do that?

…

On Fri, 6 Dec 2024, 14:31 tool4ever, ***@***.***> wrote: I guess one of us should test it ingame, not sure that's been done yet? — Reply to this email directly, view it on GitHub <#6596 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABTWPJ7C66VGQWNDZ7BVMJL2EGYMZAVCNFSM6AAAAABSDPLTNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRTGM3TMMZWG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[Agetian]

I'll see if I can give it a test run this weekend too :)

[Agetian]

Ran some basic tests, it compiles fine and runs OK, shows the format, lets me select and play it both on the main tab and in the editor tab. It does require a bit of a manual intervention to reset the editor layout in order for the new tab to show up, but that, I guess, will simply deserve a note in release notes (so that the player clicks the Reset editor layout button in the settings). Not sure if there's a clean way to upgrade the player's editor layout from the previous version tbh.