Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out main loop step for easier testing and AI dev: now with a feature flag! #5951

Closed

Conversation

marthinwurer
Copy link
Contributor

  • Broke out the main game loop into mainLoopStep() and setupFirstTurn()
  • Added a feature flag in settings to enable it for games
  • Implemented some basic combat tests
  • Ported some SpellAbilityPickerSimulationTests over to simply SpellAbilityPickerTests
  • Added a (currently ignored) game fuzzing test
  • Added some basic combat tests
  • Probably more, I wrote most of this two weeks ago

@Hanmac
Copy link
Contributor

Hanmac commented Aug 19, 2024

I don't see why public void startFirstTurn(Player goesFirst, Runnable startGameHook) can't call the new mainGameLoop() there too

no need to have the code duplicated

@tool4ever
Copy link
Contributor

Well, I guess this attempt looks less risky than your previous one :p
Imo a preference is overkill though and might actually make things harder since users switching that around would lead to inconsistent reports (even with the log print)

Copy link

github-actions bot commented Oct 6, 2024

This PR has not been updated in a while nad has been marked on stale. Stale PRs will be auto closed

@marthinwurer
Copy link
Contributor Author

Closing to have #6727 be the main effort for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep no stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants