forked from NoCheatPlus/NoCheatPlus
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mostly 1.8 block fixes & 1.13+ modules that don't work. #69
Open
MarkElf
wants to merge
36
commits into
CaptainObvious0:master
Choose a base branch
from
MarkElf:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing 1.13_r2
Still missing 1.13_r2
Spit out an error, I guess I didn't remove it when compiling before.
3/3 - Fixes wooden pressure plates on 1.8. Not affected by multi-version plugins.
This isn't needed because it was defined earlier under 1.9 blocks so the flags won't get used unless the server is on 1.9. We don't need to define grass_path twice pointlessly.
Dropped a file and I guess it was a bit dated compared to the current version. // (wood pressure plate change 1/3)
Doesn't behave like cobweb. Said we would set it as passible a while ago.
Tested with 1.12. Change 1/2
Fix glass panes, change 2/2.
Apparently, the wiki says the original name was 'waterlilly' not 'water_lilly'. https://minecraft.gamepedia.com/Lily_Pad
Prevent players from walking on water or in air with a very low delta between y distances.
There is a space between them. 🤦♂
Oddly this compiles but 'wood_plate' still flags for fast mining on 1.8. Values checked against wiki and they're 1:1.
-Bob Ross
Needed to remove glass panes from the other one anyway bc FastMine fp.
Lots of trial and error. Again, didn't work because I set the material bridge to stone pressure plate and it inherited hardness/mining speeds.
Still does nothing. 🤷♂
Just going to drop and replace from now on.
Is there a better way to do is? Probably. Can I be bothered to kill an hour to find that way? Nope. The "// Instant break and fully passable." section does not accept "MaterialUtil.CORAL_PARTS"
Last one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.