Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow OpenSubsonic extension check on low security servers #268

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mytja
Copy link

@mytja mytja commented Jul 16, 2024

Some servers, such as Nextcloud/Owncloud Music don't support token-based authentication. This made lyrics unavailable to clients connecting to such servers. This commit fixes this behaviour, allowing clients with passwords to ping server to query if it's OpenSubsonic and query all available extensions.

Before:

No time-synchronized lyrics

Now:

Screenshot_20240716-235720_Tempo

Some servers, such as Nextcloud/Owncloud Music don't support token-based authentication. This made lyrics unavailable to clients connecting to such servers. This commit fixes this behaviour, allowing clients with passwords to ping server to query if it's OpenSubsonic and query all available extensions.
@mytja mytja marked this pull request as draft July 16, 2024 22:05
@mytja
Copy link
Author

mytja commented Jul 16, 2024

I think I have another problem, but I don't think it's related to my commit. However, I might be totally wrong.

After switching to a song with no lyrics available on the server (in my case "The Night We Met") from a song (in my case "Offline") which has lyrics available both from getLyrics endpoint (plain text lyrics), as well as getLyricsFromSongId endpoint (timestamped), the app would at first crash before this commit (5062adf) was implemented. Now it doesn't crash, it only shows plain text lyrics from getLyrics endpoint from previous song ("Offline") on a song without lyrics ("The Night We Met").

Attaching the screen recording to better describe the situation

screen.mp4

@mytja mytja marked this pull request as ready for review July 16, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant