-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scons] Bump python_max_p1_version to 3.13 #1648
Conversation
I think we also need to bump the CI runner configuration to make sure we test on 3.12. |
Thanks, I added 3.12 to the CI configs. |
It looks like we might need to bump Cython to fix that build, but I'm not sure why it's only failing on macOS. Very strange. |
As far as I can see, the cython version is the same across all builds (3.0.6). I believe it is just using an old setuptools version for the macos build, which I hopefully resolved in f0f7d28. |
That seems to have fixed it. The remaining CI errors look the same as in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1648 +/- ##
==========================================
- Coverage 72.68% 72.68% -0.01%
==========================================
Files 370 370
Lines 56298 56302 +4
Branches 20403 20403
==========================================
+ Hits 40922 40923 +1
- Misses 12369 12371 +2
- Partials 3007 3008 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @matthiasdiener, this looks good to me.
Followup of #1604, #1612. See also conda-forge/cantera-feedstock#35 for context.
Changes proposed in this pull request
If applicable, fill in the issue number this pull request is fixing
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build
&scons test
) and unit tests address code coverage