-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate YAML API documentation in doxygen #1548
Conversation
ed450e2
to
e56a86f
Compare
e56a86f
to
8c82db1
Compare
eb9affb
to
bd4108f
Compare
78e7f8d
to
7c3a01c
Compare
dd478eb
to
cfea19e
Compare
cfea19e
to
69d2233
Compare
Use @ to prefix Doxygen commands
There are differences in output between Doxygen 1.9.1 and 1.9.7, where the former uses the top-level header as the @page title automatically. For newer Doxygen versions, those links are broken. Also, a space in code fencing does not work in newer Doxygen.
69d2233
to
24f6787
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is interesting as a proof of concept, but I'd like to defer considering a change this significant beyond the release of Cantera 3.0 and consider it as part of the larger documentation reorganization that we were discussing in Cantera/enhancements#178. I will note a couple of concerns here, but would suggest that they don't warrant resolving immediately:
- This seems to be based off of an out-of-date version of the
website
repo, and is missing some relatively recent changes I made to make clarify the components of a phase entry versus the top level elements/species/reactions sections. - I notice that there seems to be no syntax highlighting at all for YAML
Thanks for the feedback! I do agree that it is a substantial refactor, but strongly believe that merging YAML tutorial and reference makes for an improved user experience (having to look up pieces at two disjoint parts of the website is imho not ideal). Whether consolidated YAML documentation goes into Doxygen (as proposed here) or Sphinx is probably not too consequential. For my own part, I believe Doxygen is slightly simpler, as cross references are handled internally, and tests only require running Regarding your comments:
|
This is largely superseded by #1572 and #1573. Regarding other items, I opened Cantera/enhancements#182. One bit I spent some time on (and which I believe may be worth porting) was to update the documentation of the coverage-dependent species YAML documentation, which I found utterly confusing. Edit: opened #1579. |
Changes proposed in this pull request
This PR documents an attempt to consolidate Sphinx documentation for YAML Input within doxygen. The test emerged from discussion in Cantera/enhancements#178; the starting point was to test doxygen's capabilities for the integration of markdown files.
This PR consolidates the following information:
Other comments:
pandoc
and manually edited (also: some content is reshuffled to take advantage of table-of-content browsing)Cantera Developer API
If applicable, fill in the issue number this pull request is fixing
Partially addresses Cantera/enhancements#178
Partial fix for Cantera/cantera-website#250 (by avoiding links between doxygen and Sphinx generated content)
If applicable, provide an example illustrating new features this pull request is introducing
Rendered content:
Format Reference
Checklist
scons build
&scons test
) and unit tests address code coverage