Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ibis): Display Snowflake constraints without memtable #957

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

ongdisheng
Copy link
Contributor

@ongdisheng ongdisheng commented Nov 27, 2024

Description

This PR resolves the issue where Snowflake foreign key relationships were not displayed during setup phase by removing the memtable function.

Screenshots

  • Snowflake tables with foreign keys defined:
    Screenshot 2024-11-28 at 8 31 13 AM

  • Snowflake tables without foreign keys:
    Screenshot 2024-11-28 at 8 35 44 AM

Fix #940

@github-actions github-actions bot added ibis python Pull requests that update Python code labels Nov 27, 2024
@ongdisheng ongdisheng marked this pull request as ready for review November 28, 2024 00:48
@ongdisheng
Copy link
Contributor Author

Hi @grieve54706 @goldmedal, could you kindly review my PR whenever you have a chance? I’d greatly appreciate your feedback. Thank you!

Copy link
Contributor

@grieve54706 grieve54706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ongdisheng.

@grieve54706 grieve54706 merged commit 2dce8b7 into Canner:main Nov 28, 2024
6 checks passed
@grieve54706 grieve54706 added this to the 0.12.3 milestone Nov 28, 2024
@ongdisheng ongdisheng deleted the issue-940 branch November 29, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ibis python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snowflake Foreign Key Relationships Not Displayed
2 participants