fix(layers): fixes geocore layers not appearing in service order

[DamonU2]

Closes #2644

Description

Sorts geocore child layers properly, in ordered layer info and legend layers.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

https://damonu2.github.io/geoview/add-layers.html
Layer: 4bece602-04cf-4520-a512-9f4d8720b683

Checklist:

• I have build (rush build) and deploy (rush host) my PR
• I have connected the issues(s) to this PR
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I have created new issue(s) related to the outcome of this PR is needed
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

---

This change is 

[Alex-NRCan]

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jolevesq)

---

packages/geoview-core/src/api/event-processors/event-processor-children/legend-event-processor.ts line 357 at r1 (raw file):

    // Reorder the array so legend tab is in synch
    const sortedLayers = layers.sort((a, b) =>
      MapEventProcessor.getMapIndexFromOrderedLayerInfo(mapId, a.layerPath) >

Same as other comment here

---

packages/geoview-core/src/api/event-processors/event-processor-children/legend-event-processor.ts line 756 at r1 (raw file):

      if (legendLayer.children.length)
        legendLayer.children.sort((a, b) =>
          MapEventProcessor.getMapIndexFromOrderedLayerInfo(mapId, a.layerPath) >

Idea, an alternative and popular way of writing a sort callback would be something like:
.sort((a, b) =>
return MapEventProcessor.getMapIndexFromOrderedLayerInfo(mapId, a.layerPath) - MapEventProcessor.getMapIndexFromOrderedLayerInfo(mapId, b.layerPath);

[DamonU2]

Reviewable status: 5 of 6 files reviewed, all discussions resolved (waiting on @Alex-NRCan and @jolevesq)

---

packages/geoview-core/src/api/event-processors/event-processor-children/legend-event-processor.ts line 357 at r1 (raw file):

Previously, Alex-NRCan (Alex) wrote…

Same as other comment here

Thanks! Changed

---

packages/geoview-core/src/api/event-processors/event-processor-children/legend-event-processor.ts line 756 at r1 (raw file):

Previously, Alex-NRCan (Alex) wrote…

Idea, an alternative and popular way of writing a sort callback would be something like:
.sort((a, b) =>
return MapEventProcessor.getMapIndexFromOrderedLayerInfo(mapId, a.layerPath) - MapEventProcessor.getMapIndexFromOrderedLayerInfo(mapId, b.layerPath);

Changed!

[jolevesq]

Reviewed 6 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @DamonU2)