fix(apostrophe): fixes issue with apostrophe breaking config #2681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -189,7 +189,7 @@ | |||
| // Create a data-config attribute and set config value on the div | |||
| const att = document.createAttribute(url ? 'data-config-url' : 'data-config'); | |||
| // Clean apostrophes in the config | |||
| att.value = JSON.stringify(mapConfig).replace(/'/g, "\\'"); | |||
| att.value = mapConfig.replace(/'/g, "\\'"); | |||
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
DamonU2
force-pushed
the
apostrophe-fix
branch
from
c208e7f to
69f175a
Compare
DamonU2
commented
Jan 10, 2025
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @Github-advanced-security[bot] and @jolevesq)
| @@ -189,7 +189,7 @@ | |||
| // Create a data-config attribute and set config value on the div | |||
| const att = document.createAttribute(url ? 'data-config-url' : 'data-config'); | |||
| // Clean apostrophes in the config | |||
| att.value = JSON.stringify(mapConfig).replace(/'/g, "\\'"); | |||
| att.value = mapConfig.replace(/'/g, "\\'"); | |||
jolevesq
merged commit 7606951
into
Canadian-Geospatial-Platform:develop
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue breaking configs by using JSON.stringify on config already stringified
Closes #2629
Type of change
How Has This Been Tested?
https://damonu2.github.io/geoview/demos-navigator.html?config=./configs/navigator/06-basic-footer.json
https://damonu2.github.io/geoview/demo-osdp-integration.html
Checklist:
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksNew and existing unit tests pass locally with my changesThis change is