Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(layers) Fixes a 'private property not on object', fixing a layer issue, and added another proj fixing another issue #2680

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(layers) Fixes a 'private property not on object', fixing a layer issue, and added another proj fixing another issue #2680

wants to merge 1 commit into from

Conversation

Alex-NRCan
Copy link
Member

@Alex-NRCan Alex-NRCan commented Jan 10, 2025 •
edited
Loading

Description

  • Fixing bug with 'Private property not on object' which was causing many issues including one when removing a layer such as (9d96e8c9-22fe-4ad2-b5e8-94a6991b744b)
  • Fixing an issue where, when removing layers, the layer configs would be removed from layer registration, but not the actual layer objects
  • Added support for EPSG:42101 projection
  • Better support of metadata urls for WMS services where GetCapabilities is in the URL already or not

Fixes #2643 #2645
Possibly fixes #2594 and #2647 and #2602 as well, as those issues seem to be working on host now
Fixes #2605

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Hosted: Jan 10 @ 15h45 : https://alex-nrcan.github.io/geoview/

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

@Alex-NRCan Alex-NRCan self-assigned this Jan 10, 2025
@jolevesq jolevesq requested review from DamonU2 and jolevesq January 10, 2025 18:03
@Alex-NRCan Alex-NRCan changed the title fix(layers) Fixes a 'private property not on object', fixing a layer issue and added another proj fixing another issue fix(layers) Fixes a 'private property not on object', fixing a layer issue, and added another proj fixing another issue Jan 10, 2025
@Alex-NRCan
- Fixed a bug with 'Private property not on object' which was causing…
8bb3ffb 
… many issues including one when removing a layer such as (9d96e8c9-22fe-4ad2-b5e8-94a6991b744b), fixing issue Canadian-Geospatial-Platform#2643.

- Fixed an issue where, when removing layers, the layer configs would be removed from layer registration, but not the actual layer objects
- Added support for EPSG:42101 projection, fixing issue Canadian-Geospatial-Platform#2645
- Fixed an issue where geocore would respond with a metadata url for a WMS already including 'GetCapabilities' wording.. Now curating that url better, fixing issue Canadian-Geospatial-Platform#2605.
- Fixed an issue where a WMS layer would show 1 feature (invalid feature) even when the response was empty (no feature)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamonU2 DamonU2 Awaiting requested review from DamonU2

@jolevesq jolevesq Awaiting requested review from jolevesq

Assignees

@Alex-NRCan Alex-NRCan

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Alex-NRCan