Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulated model output #231

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

CallmeNafiy
Copy link
Contributor

Changed model output from json to Context class
Updated GroupOp by removing preprocess_fn as value dictionary of all nodes are Context class now

RESPONSE: data,
ERROR: "No errors.",
}
return [Context(context=data)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq: why are you using a list here instead of directly returning Context(context=data)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this because LmModel._serialize takes in List[Context]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants