Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update links in docker README #93

Merged
merged 1 commit into from
Nov 22, 2023
Merged

update links in docker README #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docker/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ docker rm [CONTAINER_NAME]
In this folder, we have the different Dockerfiles for using `pykoi`.

## Building from the Repo
Some of these examples build from the pykoi repository. For example, you can reference the Dockerfile in the [`pykoi-retrieval-huggingface`](./pykoi-retrieval-huggingface/Dockerfile).
Some of these examples build from the pykoi repository. For example, you can reference the [Dockerfile](./pykoi-retrieval-huggingface/Dockerfile) in `pykoi-retrieval-huggingface`.

In order to build the docker image, first ensure you are in the base directory of the `pykoi` repo. __You will encounter errors if you're not in the base directory__

Expand All @@ -164,7 +164,7 @@ docker build -t pykoi:0.1 . -f docker/pykoi-retrieval-huggingface/Dockerfile
```

## Building based on pykoi library
There are also examples to build based on the `pykoi` package. These examples install `pykoi` via `pip` and run different applications from there. This relies on the latest pypi released versions. To see an example, you can reference the Dockerfile in [`pykoi-cpu-custom`](./pykoi-cpu-custom/Dockerfile).
There are also examples to build based on the `pykoi` package. These examples install `pykoi` via `pip` and run different applications from there. This relies on the latest pypi released versions. To see an example, you can reference the [Dockerfile](./pykoi-cpu-custom/Dockerfile) in `pykoi-cpu-custom`.

1. `pykoi-cpu`: The base image for the cpu-based usage.
1. `pykoi-cpu-custom`: When you run this docker image, try to modify the `app.py` and mount it when running the docker container.
Expand Down