Add file ovewrite handling for CSV save #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jojortz
commented
Oct 5, 2023
jojortz
commented
- add /file_exists/ route to application.py to check if file exists
- implement dialog to check if user wants to overwrite existing file in DownloadModal component
jwilber
reviewed
Oct 6, 2023
| @@ -34,6 +34,19 @@ | |||
| } | |||
| }; | |||
|
|
|||
| const handleSubmit = async (e) => { | |||
There was a problem hiding this comment.
Nice!. May be worth destucturing the file_exists directly, since we're just using file_exists there
e.g.
const { file_exists } = await response.json();
then
if (file_exists) {
...
} else {
...
}
};
There was a problem hiding this comment.
Just updated with this!
|
LGTM! Good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.