Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mlu conference #71

Merged
merged 4 commits into from
Sep 27, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 32 additions & 3 deletions pykoi/application.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
"""Application module."""
import asyncio
import os
import re
import socket
import subprocess
import threading
import time

Expand Down Expand Up @@ -746,13 +749,38 @@ async def read_item(
self._telemetry.capture(start_event)

if self._share:
public_url = ngrok.connect(self._host + ":" + str(self._port))
print("Public URL:", public_url)
import nest_asyncio

nest_asyncio.apply()
command = f"ssh -o StrictHostKeyChecking=no -R 80:{self._host}:{self._port} [email protected]"
process = subprocess.Popen(
command,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
shell=True,
text=True,
)
# Get the public URL without waiting for the process to complete
while True:
line = process.stdout.readline()

if not line:
break
# return url
match = re.search(r"(\bhttp[s]?://[^\s]+)", line)
if match:
public_url = match.group(1)
print("Public URL:", public_url)
break

# The process will continue to run in the background here
import uvicorn

uvicorn.run(app, host=self._host, port=self._port)
print("Stopping server...")
ngrok.disconnect(public_url)

# Once done, you may choose to terminate the ssh process
process.terminate()
else:
import uvicorn

Expand All @@ -769,6 +797,7 @@ def display(self):
"""
Run the application.
"""
print("hey2")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove this print. Also, please remove the pyngrok in pyproject.toml.

import nest_asyncio

nest_asyncio.apply()
Expand Down