Add the initial docker file #51
Conversation
example/chatbot/openai_model_demo.py
Outdated
| app = pykoi.Application(debug=False, share=False) | ||
| app = pykoi.Application( | ||
| debug=False, | ||
| share=True) |
There was a problem hiding this comment.
nit: we can revert all these changes and leave boilerplate code as before.
docker/pykoi-gpu/Dockerfile
Outdated
| python3 -m pip install --no-cache-dir \ | ||
| torch \ | ||
| torchvision \ | ||
| torchaudio && \ | ||
| python3 -m pip install --no-cache-dir \ | ||
| accelerate \ | ||
| datasets \ | ||
| hf-doc-builder \ | ||
| huggingface-hub \ | ||
| Jinja2 \ | ||
| librosa \ | ||
| numpy \ | ||
| scipy \ | ||
| tensorboard \ | ||
| transformers \ | ||
| omegaconf \ | ||
| pytorch-lightning \ | ||
| xformers \ | ||
| pykoi |
There was a problem hiding this comment.
for the gpu version: I think we only need to install?
pip3 install pykoi && pip3 install torch --index-url https://download.pytorch.org/whl/cu118
There was a problem hiding this comment.
Yes, but for using huggingface model, more packages/library is needed. I will only keep the torch one.
| 1. `pykoi-cpu`: The base image for the cpu-based usage. | ||
| 2. `pykoi-cpu-custom`: When you run this docker image, try to modify the `app.py` and mount it when running the docker container. | ||
|
|
||
| To run a docker container, we can use the following command: |
There was a problem hiding this comment.
nit: considering that we have not push the docker images into the docker hub, we can add below steps regarding how your build docker images.
- build the base image using dockerfile
docker/pykoi-cpu/Dockerfileinto docker image"weialexchen/pykoi-cpu:base" - build the app image using dockerfile
docker/pykoi-cpu-custom/Dockerfileinto docker imageweialexchen/pykoi-cpu:app
nit: change we change weialexchen to pykoi, so we can push them into dockerhub easily later.
There was a problem hiding this comment.
Sure, please create a pykoi docker account then.
There was a problem hiding this comment.
dm you with the dockerhub account and access token for dockerhub push
docker/pykoi-cpu-custom/Dockerfile
Outdated
| EXPOSE 5000 | ||
|
|
||
| # For dev | ||
| CMD ["python", "app.py"] |
There was a problem hiding this comment.
nit: add an empty line at the end of dockerfile
docker/pykoi-gpu/Dockerfile
Outdated
| xformers \ | ||
| pykoi | ||
|
|
||
| CMD ["/bin/bash"] |
There was a problem hiding this comment.
nit: add an empty line at the end of dockerfile
|
LGTM! |
1 similar comment
|
LGTM! |
Add the initial docker file. TODO: Remove the OPENAI token, try to make it as environmental variables && add GPU function support.