Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

token support #48

Closed
wants to merge 3 commits into from
Closed

token support #48

wants to merge 3 commits into from

Conversation

andyli11
Copy link
Contributor

@andyli11 andyli11 commented Oct 4, 2024

Feature

Below is the code from the api-construct file in the RT CDK. Identify sources are both x-api-key and Authorization.

        // Add custom authorizer
        const lambdaAuthorizer = new apigw.RequestAuthorizer(this, 'LambdaAuthorizer', {
            handler: lambdaAuthorizerFn,
            identitySources: [apigw.IdentitySource.header('x-api-key'), apigw.IdentitySource.header('Authorization')],
        });

After testing and reviewing AWS docs, ALL identity sources must be present in the request header.

For more details, see: https://stackoverflow.com/questions/76789499/api-gateway-multiple-identity-sources

Tested

NOTES:

  • ChatGPT says that only one of x-api-key and Authorization need to be in the header to pass but that is INCORRECT and disproven through AWS docs and testing.
  • Build failed because changes are associated with RT CDK pr.

@andyli11 andyli11 requested a review from Sdddell as a code owner October 4, 2024 20:30
any_parser/any_parser.py Outdated Show resolved Hide resolved
@CambioML
Copy link
Collaborator

CambioML commented Oct 4, 2024

Let's fix the linter.

@andyli11 andyli11 closed this Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants