-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Python SDK & bash script #22
Conversation
qq: do we run a quick test for all notebooks in this repo after the change? |
if [ "$func" == "extract" ]; then | ||
upload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qq: should upload out of the if, elif, so upload will also apply
for parse logic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm. It looks like this is a bug in previous code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's double check to make sure our notebook is still working as expected. For next PR, if you can add in the comment regarding what have been tested, it will help ease the review process a lot.
if [ "$func" == "extract" ]; then | ||
upload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm. It looks like this is a bug in previous code.
I have tested all the examples, they worked fine except |
No description provided.