Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address comments #14

Merged
merged 2 commits into from
Apr 11, 2024
Merged

address comments #14

merged 2 commits into from
Apr 11, 2024

Conversation

jojortz
Copy link
Contributor

@jojortz jojortz commented Apr 11, 2024

  • remove additional PII
  • display report images
  • add explanations
  • change report_data to medical_cbc_report_data
  • move expected_result to external file
  • rename notebook to extract_key_values_from_cbc_reports_in_different_layout

@jojortz jojortz requested a review from Sdddell as a code owner April 11, 2024 06:06
CambioML
CambioML approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@CambioML CambioML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CambioML CambioML merged commit e457ea6 into main Apr 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CambioML CambioML CambioML approved these changes

@Sdddell Sdddell Awaiting requested review from Sdddell Sdddell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jojortz @CambioML