various changes to table view, add timestamp to json. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user adds #sorted hash to the end of the url, the games list won't be randomized. They won't be sorted, but they will appear in the same order they're in in the file. This is a silent action--users have to already know about this to use it. Reason: I've had several people PM me on steam complaining that the list is randomized. I see no problem with this, as it helps you find out about different games. However, I can also see it annoying someone looking through the entire list. Since I'm unwilling to make changes that affect things you've done, I've told people to submit an issue if they don't like it. In the meantime, they can use this to not have the list sorted.
This reverts commit d18a3e7.
Merge updates
I've added support for a timestamp to be automatically generated in json.html. The column is added to table view, but hidden by default as no games have dates yet.
json.html enforces consistency because it autogenerates. it also has further, more detailed instructions for adding to the file and adds the timestamp automatically.
Some games have a steam url defined even though the game isn't listed as giving out a key. In this case, show the link as usual, but fade it out and set title to a warning to indicate a key is not provided.
Moved the options to the top to make them a little more visible. The steam link was commented out. I've re-enabled it as I intend to continue posting updates to the group, though I left it at the bottom as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add timestamps to json when using generator, and new (hidden by default) column for the date (someone wanted a way to see what's new since last time, was simple to implement).
Move column options to top.
Change edit link to point to json generator.
Show grayed out steam link if a url has been given but no key is provided.
Show link to steam group at bottom of page.