Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retroactive review of NED (and related) documentation changes #27

Draft
wants to merge 74 commits into
base: review-ned-edits
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
74 commits
Select commit Hold shift + click to select a range
4852d57
changes as per discussion in https://github.com/Caltech-IPAC/firefly-…
Jan 10, 2022
3ae96cc
further changes as per discussion in https://github.com/Caltech-IPAC/…
Jan 10, 2022
adfe994
changes as per discussion in https://github.com/Caltech-IPAC/firefly-…
Jan 10, 2022
186974b
update docker environment to build and run firefly-help
loitly Feb 2, 2022
fe2b67f
update react-scripts to version 4.0.3 to address security vulnerabili…
loitly Feb 2, 2022
122ce19
correct docker image name
loitly Feb 2, 2022
36c8dc7
add /onlinehelp to root path
loitly Feb 2, 2022
a71c0fd
add back the feature to create zip file from build
loitly Feb 11, 2022
935233c
remove restart from docker-compose
loitly Feb 23, 2022
c977894
adding a selection option i didn't know about (ok to go anytime)
Mar 24, 2022
91be913
typo
Mar 29, 2022
4dd5ac3
merging
Mar 29, 2022
b1b34cc
typo
Mar 29, 2022
26b2e3a
doc change request from FIREFLY-787 -- ok to go anytime
May 31, 2022
7b6b687
adding IPAC Logo to about page; can go out anytime
Jul 18, 2022
209439e
Software update
loitly Jul 19, 2022
95e9b68
changes for pinned plots
Jul 26, 2022
176abab
Merge branch 'master' of https://github.com/Caltech-IPAC/firefly-help
Jul 26, 2022
886c3e1
click to search TAP stuff
Jul 26, 2022
8a18d32
lost anchor
Jul 27, 2022
1ddb069
updated as per FIREFLY-1027
Jul 27, 2022
61aa063
more changes FIREFLY-1027
Jul 27, 2022
7495468
more from FIREFLY-1037
Jul 27, 2022
e5a75b3
more FIREFLY-1027
Jul 27, 2022
fbaed98
typo
Aug 17, 2022
5f451d0
Merge branch 'master' of https://github.com/Caltech-IPAC/firefly-help
Aug 17, 2022
b297c05
typo again
Aug 17, 2022
b67497d
typos
Aug 17, 2022
f2586fb
tweaks for typos, broken anchors
Aug 19, 2022
22b4502
tweaks for most recent firefly patches
Sep 6, 2022
42a18b6
changes for "add a column to a table"
Jan 21, 2023
67b903a
docs for image click-to-search
Jan 22, 2023
3560ea2
combine charts docs
Jan 22, 2023
1f8c3eb
trying to fix errors but not succeeding
Jan 22, 2023
95e398b
found my error!
Jan 22, 2023
5956ad3
clarifying language
Mar 8, 2023
6a07df3
updating for latest version of firefly (only a *little* late!)
May 3, 2023
3a50000
forgot there were changes to the plot dialog for errors
May 30, 2023
857a336
changes for new firefly; this for property sheets
Aug 9, 2023
78aa7d3
TAP objid searches
Aug 17, 2023
289c810
additional tip
Aug 18, 2023
e5af497
checking this into git solely in case my desktop dies over the weekend
Feb 10, 2024
9f7f309
updates for new firefly version
Feb 12, 2024
4d0fb8d
the last of the changes? for the firefly patch release
Feb 12, 2024
bc0a613
tweak to tables docs
Feb 12, 2024
c90e8ae
myriad fixed typos - see IRSA-5891
Feb 20, 2024
97a589c
change pulldown to drop-down everywhere (also IRSA-5891)
Feb 20, 2024
835fab1
tweaks to add a feature I didn't know was in there
Feb 23, 2024
1d0cee8
UWS typo
Feb 26, 2024
f5a59ea
adding a warning symbol to text for 'tips and troubleshooting'
Mar 11, 2024
fe36c20
changes as per IRSA-5940 (same ticket as my prior chagnes)
Mar 11, 2024
36afb18
fix href detection bug
loitly Apr 8, 2024
eff3fe2
first wave of JoyUI changes (not complete yet)
Apr 8, 2024
7c92e08
Merge branch 'master' of https://github.com/Caltech-IPAC/firefly-help
Apr 8, 2024
15dbdc8
Fix pdf generation
loitly Apr 9, 2024
a40f1f2
JoyUI rewrite
Apr 9, 2024
5b9f489
Merge branch 'master' of https://github.com/Caltech-IPAC/firefly-help
Apr 9, 2024
c8e27f0
fixing the headers and anchors
Apr 9, 2024
8878178
lingering reference to IRSA Viewer
Apr 10, 2024
3a56f64
typo!
Apr 10, 2024
edea8d7
Refresh firefly-help
loitly Apr 10, 2024
7ed9244
typo!
Apr 10, 2024
a9b8e45
make navbar fixed, not scrolled away
loitly Apr 11, 2024
878cef8
Merge pull request #38 from Caltech-IPAC/2024-refresh
loitly Apr 11, 2024
f96851f
Refresh firefly-help
loitly Apr 10, 2024
25eda03
Merge pull request #39 from Caltech-IPAC/2024-refresh
loitly Apr 11, 2024
c8bf140
lost an item re: rolling over from polygons to points
May 10, 2024
c3a3ebd
changes reflecting new HiPS menus in upper left of coverage image
Jun 7, 2024
9b137d9
clarifying text
Jul 25, 2024
494e810
updated as per FIREFLY-1437
Aug 12, 2024
b52e9d4
FIREFLY-1559: Upgrade Java from version 17 to 21
loitly Sep 24, 2024
26cc2b8
Merge pull request #40 from Caltech-IPAC/FIREFLY-1559-java-21-upgrade
loitly Sep 24, 2024
39a0002
upates for new version of firefly
Oct 19, 2024
d1928a7
Merge branch 'master' of https://github.com/Caltech-IPAC/firefly-help
Oct 19, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 3 additions & 0 deletions .dockerignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**/build
**/.gradle
**/node_modules
40 changes: 24 additions & 16 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,28 +1,36 @@

FROM node:12.22.4-slim AS deps
WORKDIR "/app"
COPY ./app/package.json ./app/yarn.lock ./
RUN yarn install --frozen-lockfile
FROM gradle:8.10-jdk21-jammy AS deps

FROM gradle:4.10-jre-slim AS builder
USER root
RUN apt-get update \
&& apt-get install -y curl htmldoc \
&& curl -sL https://deb.nodesource.com/setup_12.x | bash - \
&& apt-get install -y htmldoc unzip wget \
# use node v18.x. may not be available via apt-get
&& curl -sL https://deb.nodesource.com/setup_18.x | bash - \
&& apt-get install -y nodejs \
&& npm install yarn -g \
&& rm -rf /var/lib/apt/lists/* \
&& mkdir -p /work
# cleanup
&& rm -rf /var/lib/apt/lists/*;

WORKDIR "/work"
COPY ./buildScript ./buildScript
COPY build.gradle settings.gradle ./
COPY --from=deps /app/node_modules ./app/node_modules
COPY ./app/package.json ./app/yarn.lock ./
RUN yarn install --frozen-lockfile

FROM deps AS builder

WORKDIR "/work"
COPY . .
COPY --from=deps /work/node_modules ./app/node_modules

ENV GRADLE_USER_HOME=/work \
GRADLE_OPTS="-Dorg.gradle.daemon=false -Dorg.gradle.internal.launcher.welcomeMessageEnabled=false"

ARG target=build
ARG env=dev

RUN gradle -Penv=${env} ${target}


FROM httpd:2.4-alpine

RUN rm /usr/local/apache2/htdocs/index.html && mkdir /usr/local/apache2/htdocs/onlinehelp

ENTRYPOINT []
CMD ["gradle", "tasks"]
#CMD ["sleep", "30m"]
COPY --from=builder /work/build/ /usr/local/apache2/htdocs/onlinehelp/
18 changes: 8 additions & 10 deletions README-docker.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,14 @@ For this reason, you will see slightly slower performance when running on MacOS

## Quick Start

#### Build
git clone https://github.com/Caltech-IPAC/firefly-help
cd firefly-help
docker compose up [--build]

To build the application, run this command in the project root's directory.
The above commands will create firefly-help repository with the latest changes then
build and run it locally on port 3000. To test, point browser to http://localhost:3000/

docker compose run <project-name>
By default, docker-compose will build the image if one does not exists. Once image is built, it will use
the existing image and will not attempt to build again. Use **--build** to force a build before starting
the container. This is needed when you're made changes to the source and wanted to rebuild before starting.

The predefined projects are listed in `docker-compose.yml` under `services`.
In this case, there is only `firefly`.

#### Run

Firefly help is a web application. To run it, point your web browser to the built `index.html`.
You can find this under the `./build/${project-name}/index.html`, i.e. `./build/firefly/index.html`
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ and other Firefly-based applications.
- Dynamically generate a PDF from the HTML pages used.

#### Dev Dependencies
- [Gradle 4.x](https://gradle.org/downloads)
- [Gradle 8.10](https://gradle.org/downloads)
Gradle is an open source build automation system.

- [Node v12+](https://nodejs.org/)
- [Node v18](https://nodejs.org/)
Javascript interpreter for command line environment, used for development tools

- [HTMLDoc](https://www.msweet.org/htmldoc/)
Expand Down
20 changes: 14 additions & 6 deletions app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,16 @@
"private": true,
"homepage": ".",
"dependencies": {
"react": "^16.13.1",
"react-dom": "^16.13.1",
"react-scripts": "3.4.1",
"lodash": "^4.17",
"rc-tree": "^1.14.9"
"@emotion/react": "^11.11.4",
"@emotion/styled": "^11.11.5",
"@mui/icons-material": "^5.15.15",
"@mui/material": "^5.15.15",
"lodash": "^4.17.21",
"rc-tree": "^5.6.5",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-scripts": "^5.0.1",
"tailwindcss": "^3.4.3"
},
"scripts": {
"start": "react-scripts start",
Expand All @@ -32,6 +37,9 @@
]
},
"babel": {
"presets": [ "@babel/preset-env", "@babel/preset-react" ]
"presets": [
"@babel/preset-env",
"@babel/preset-react"
]
}
}
9 changes: 6 additions & 3 deletions app/public/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,19 @@
display: inline-flex;
align-items: center;
}
.dark .rc-tree-node-content-wrapper.rc-tree-node-selected {
background-color: black;
}
#title {
color: white;
font-size: 25pt;
font-family: sans-serif;
text-shadow: 1px 1px 3px rgba(195,235,234, 0.79);
}
</style>
<body>
<body class="h-screen">

<div id="page-root">
<div id="page-root" class="flex flex-col h-full">
<div id="banner">
<img src="firefly/img/fftools-logo-offset-small-75x75.png">
<div id="title">Firefly</div>
Expand All @@ -31,7 +34,7 @@
<!--
This HTML file is a template. app-root is where the application with mount to.
-->
<div id="app-root"></div>
<div id="app-root" class="flex flex-grow overflow-hidden"/>
</div>
</body>
</html>
Loading