Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session authentication #33

Merged
merged 20 commits into from
Nov 30, 2023
Merged

Session authentication #33

merged 20 commits into from
Nov 30, 2023

Conversation

3milyfz
Copy link
Member

@3milyfz 3milyfz commented Nov 26, 2023 •
edited
Loading

Description

  • Now when users end a session, they cannot go back to the session chat (shows alert and redirects to welcome page)
  • Modified invalid code alert

Note: Please test locally if you do a code review! I want to make sure it works on other computers.

@3milyfz 3milyfz self-assigned this Nov 26, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 26, 2023 •
edited
Loading

✅ Deploy Preview for callhub ready!

Name Link
🔨 Latest commit f9954ee
🔍 Latest deploy log https://app.netlify.com/sites/callhub/deploys/6568072d1d6db70008280d69
😎 Deploy Preview https://deploy-preview-33--callhub.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

lucieyang1
lucieyang1 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@lucieyang1 lucieyang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes! The new alerts are very pretty.

  • Code is generally very clear and easy to read.
  • Tested is locally, looks good.

@3milyfz 3milyfz merged commit c6cb7e8 into main Nov 30, 2023
4 checks passed
@3milyfz 3milyfz deleted the session-authentication branch November 30, 2023 03:55
@3milyfz 3milyfz mentioned this pull request Dec 2, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucieyang1 lucieyang1 lucieyang1 approved these changes

@sarinali sarinali Awaiting requested review from sarinali

@zjayee zjayee Awaiting requested review from zjayee

Assignees

@3milyfz 3milyfz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@3milyfz @lucieyang1 @sarinali