testing the workflows #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjayee
reviewed
Nov 2, 2023
There was a problem hiding this comment.
Is this intentionally added?
zjayee
reviewed
Nov 2, 2023
| // 1 mb = 1024 * 1024 | ||
|
|
||
| try (FileInputStream fileInputStream = new FileInputStream(pdfFile)) { | ||
| if (pdfFile.length() > 16 * 1024 * 1024) { |
There was a problem hiding this comment.
Can we make 16 * 1024 * 1024 a constant?
Eg.
MB_TO_BITS = 1024 * 1024
fileSizeLimit = 16 * MB_TO_BITS
| } | ||
|
|
||
| @GetMapping("/checkFiles") | ||
| public void checkPDFS() { |
| DocumentRepository documentRepository; | ||
| @GetMapping("/upload") | ||
| public String uploadPDF () { | ||
| String currentDirectory = System.getProperty("user.dir"); |
There was a problem hiding this comment.
From my understanding this endpoint should take in the pdf to be uploaded as a parameter to send it to the MongoDB, or are we getting hardcoded files from within the project?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an Exception for illegal PDF uploads, serializes and encodes PDFs into bInary for mongodb storage. Currently storing a static pdf located in the local repository. Created new endpoint routes.