Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests for session use case #40

Merged
merged 8 commits into from
Dec 4, 2023
Merged

Added tests for session use case #40

merged 8 commits into from
Dec 4, 2023

Conversation

zjayee
Copy link
Contributor

@zjayee zjayee commented Dec 4, 2023 •
edited
Loading

Description

Added tests for session use case. Line coverage is >90% for interactor and >70% for all other classes.
image

Type of change

Tests

@zjayee zjayee self-assigned this Dec 4, 2023
sarinali
sarinali approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@sarinali sarinali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, make sure you include a screenshot of your test coverage

@zjayee zjayee merged commit 9d51b46 into master Dec 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarinali sarinali sarinali approved these changes

@3milyfz 3milyfz Awaiting requested review from 3milyfz

@lucieyang1 lucieyang1 Awaiting requested review from lucieyang1

Assignees

@zjayee zjayee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zjayee @sarinali @lucieyang1