Javadoc and ca #39
Merged
Javadoc and ca #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allhub-backend into javadoc-and-CA
lucieyang1
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
- Coding style is great, easy to understand
- Manually tested, seems like it still works as before! Tests are working well.
- Test coverage is very good! I added some comments for lines the tests didn't cover, not sure if coverage there is possible.
- Clean architecture looks good!
- Javadoc looks good as well, present for public methods
LGTM, very nice :)
| try { | ||
| return Optional.of(documentRepository.save(file)); | ||
| } catch (Exception e) { | ||
| return Optional.empty(); |
There was a problem hiding this comment.
out of curiosity, why return an empty Optional here instead of an exception?
There was a problem hiding this comment.
its handled later i think an if checks for an empty
| private void setFileData() { | ||
| try { | ||
| this.data = this.serializePDF(); | ||
| this.fileData = new FileDocument(this.name, this.data, LocalDate.now()); |
There was a problem hiding this comment.
is it possible to test these lines?
There was a problem hiding this comment.
this is tested in update pdf!
| Optional<FileDocument> result = fileDataAccessObject.uploadFile(fileInputData.getFileData()); | ||
| headers.setContentType(MediaType.TEXT_PLAIN); | ||
| FileOutputData outputData = new FileOutputData(); | ||
| if (result.isEmpty()) { |
There was a problem hiding this comment.
is it possible to test these lines?
There was a problem hiding this comment.
sorry no, i don't think it is very easy to test this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CA fix to File endpoints with added Javadoc comments for most public methods
Please delete options that are not relevant.
How Has This Been Tested?
Through the frontend manually to ensure all enpoints act as before