Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added end session endpoint #36

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Added end session endpoint #36

merged 3 commits into from
Dec 1, 2023

Conversation

zjayee
Copy link
Contributor

@zjayee zjayee commented Nov 29, 2023

Description

Added endpoint for ending session.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manual test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@zjayee zjayee self-assigned this Nov 30, 2023
@zjayee zjayee changed the title Added end session endpoint [WIP] Added end session endpoint Nov 30, 2023
@zjayee zjayee changed the title [WIP] Added end session endpoint Added end session endpoint Dec 1, 2023
@sarinali sarinali self-requested a review December 1, 2023 18:45
sarinali
sarinali reviewed Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@sarinali sarinali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarinali sarinali self-requested a review December 1, 2023 18:46
sarinali
sarinali approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@sarinali sarinali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zjayee zjayee merged commit 3f789d7 into master Dec 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarinali sarinali sarinali approved these changes

@3milyfz 3milyfz Awaiting requested review from 3milyfz

@lucieyang1 lucieyang1 Awaiting requested review from lucieyang1

Assignees

@zjayee zjayee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zjayee @sarinali