Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add messages to session #32

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Add messages to session #32

merged 2 commits into from
Nov 27, 2023

Conversation

zjayee
Copy link
Contributor

@zjayee zjayee commented Nov 26, 2023

Description

Adds messages to current session

Note: will move code to session data access once that pull request is merged

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manual testing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code

@zjayee zjayee requested a review from lucieyang1 November 26, 2023 23:19
@zjayee zjayee self-assigned this Nov 26, 2023
lucieyang1
lucieyang1 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@lucieyang1 lucieyang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Coding style: easy to read, well structured, access modifiers look good
  • Correctness: manually tested, works locally for me!

Amazing! Happy that it is working now :))

@zjayee zjayee merged commit f287033 into master Nov 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucieyang1 lucieyang1 lucieyang1 approved these changes

Assignees

@zjayee zjayee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zjayee @lucieyang1