Pdf session connection

[sarinali]

Description

Created endpoint for linking PDF uploads to the current active session

Type of change

• New feature (non-breaking change which adds functionality)

2023-11-24.12-03-13.mp4

How Has This Been Tested?

Tested using two JUnit Tests:

@Test
    void testPDFLinkValidSession() throws Exception {
        String currentDirectory = System.getProperty("user.dir");
        String pathName = currentDirectory + "/src/main/java/callhub/connect/pdfs/fall2023.pdf";
        File pdfFile = new File(pathName);
        MockMultipartFile sampleFile = new MockMultipartFile(
                "file",
                pdfFile.getName(),
                "application/pdf",
                new FileInputStream(pdfFile));


        when(documentRepository.save(any())).thenReturn(new FileDocument(
                "MockFile",
                new Binary("sample pdf content".getBytes()),
                LocalDate.now()));

        Session mockSession = new Session(true, "ABCDEF");

        // Mock the behavior of the sessionRepository.save() method
        when(sessionRepository.getSessionsByActiveAndCode(true, "ABCDEF")).thenReturn(mockSession);

        MockMultipartHttpServletRequestBuilder multipartRequest =
                MockMvcRequestBuilders.multipart("/files/session_add_pdf");
        mockMvc.perform(multipartRequest.file(sampleFile).param("session", "ABCDEF").param("name", "MockFile")).andExpect(status().isOk());
    }

    @Test
    void testPDFLinkInvalidSession() throws Exception {
        String currentDirectory = System.getProperty("user.dir");
        String pathName = currentDirectory + "/src/main/java/callhub/connect/pdfs/fall2023.pdf";
        File pdfFile = new File(pathName);
        MockMultipartFile sampleFile = new MockMultipartFile(
                "file",
                pdfFile.getName(),
                "application/pdf",
                new FileInputStream(pdfFile));


        when(documentRepository.save(any())).thenReturn(new FileDocument(
                "MockFile",
                new Binary("sample pdf content".getBytes()),
                LocalDate.now()));

        Session mockSession = new Session(true, "ABCDEF");

        // Mock the behavior of the sessionRepository.save() method
        when(sessionRepository.getSessionsByActiveAndCode(true, "ABCDEF")).thenReturn(mockSession);

        MockMultipartHttpServletRequestBuilder multipartRequest =
                MockMvcRequestBuilders.multipart("/files/session_add_pdf");
        mockMvc.perform(multipartRequest.file(sampleFile).param("session", "123456").param("name", "MockFile")).andExpect(status().isBadRequest());
    }```

[3milyfz]

Good job!

• Tested locally and works as expected
• I added a few comments on some changes I would make
• Most are minor things including missing import statements and potential duplicate code that can be refactored

[3milyfz]

Duplication in Test Setup:

• There is some duplication in setting up the MockMultipartFile in both test methods.
• Consider refactoring this into a separate method or a @beforeeach setup method to reduce duplication!

[sarinali]

remind me to fix this after i merge

[zjayee]

Can we wait for clean architecture code to be merged first before merging this code

[zjayee]

Overall good with some minor comments

[zjayee]

Can we remove this file and create a blank pdf in the test setup for testing instead?

[zjayee]

Same thing here

[zjayee]

Approved + future refactoring