Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add Cypress tests #20

Closed
wants to merge 3 commits into from
Closed

Conversation

dvmichaelpeterseil
Copy link

@dvmichaelpeterseil dvmichaelpeterseil commented Mar 23, 2023

Caleydo/coral#57

Developer Checklist (Definition of Done)

An initial cypress test has been added, replicating the functionality as seen in the Coral official demonstration video.

The test is functionally complete, however a second pass is preferable to add programmatic 'best practices' (i.e. add data-testid for most getters, etc.)

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

@thinkh thinkh changed the title dvMike/57 add cypress**Issue** Add Cypress tests Apr 4, 2023
@thinkh thinkh changed the title Add Cypress tests test: add Cypress tests Apr 4, 2023
@thinkh thinkh linked an issue Apr 4, 2023 that may be closed by this pull request
@dvvanessastoiber dvvanessastoiber mentioned this pull request Jul 12, 2023
4 tasks
@thinkh
Copy link
Member

thinkh commented Oct 13, 2023

Obsolete with Caleydo/coral#64.

@thinkh thinkh closed this Oct 13, 2023
@thinkh thinkh deleted the dvMike/57_add-cypress branch October 13, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Cypress Tests
2 participants