Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple child Tracking #179

Merged
merged 8 commits into from
Feb 17, 2024

Conversation

squealingpiggies
Copy link
Contributor

The changes to code for the test simulations in #175

Copy link
Owner

@Calandiel Calandiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The children button seems to be too small:
image

@Calandiel
Copy link
Owner

Besides that, seems fine, wdyt? @ineveraskedforthis

Copy link
Collaborator

@ineveraskedforthis ineveraskedforthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@squealingpiggies
Copy link
Contributor Author

I don't know if these changes should actually be included, it was more of a proof of concept to see how it affected growth (that was asked for in the related issue discussion). It should probably be looked at a bit more in depth before merging.

@Calandiel
Copy link
Owner

Child tracking and the UI for it at least ought to be included, imhp

@squealingpiggies
Copy link
Contributor Author

squealingpiggies commented Feb 15, 2024

Ok, fair enough. I fixed the UI and made a very generic list-widget that takes any list and a table of columns from the character-list widget which is shown off with an additional tab in characters that shows their warriors. The list-widget still needs to have the bounds be anchors and stretch the columns using the render_closures as weighted widths and minimum heights instead of pixel values but it is getting to be both very versatile and easy to use.

@squealingpiggies
Copy link
Contributor Author

One last additon to ui changes. I added scaling calculations to the table widget from engine.ui to weight the widths of the render closures and scale table items into the rect provided. It seems to work for both the standard character-list and the generic list-widget without changes to either's code.

@Calandiel
Copy link
Owner

Seems fine to me, thanks!

@Calandiel Calandiel merged commit 033b960 into Calandiel:master Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants