Switch render order of block aligned and unaligned block faces #2038
Conversation
renders faces better than before. unsure if this has other unintended side effects, it seems to render fine but does this negatively affect performance if those faces are done before axis aligned ones? potential fix for honey & slime internal faces
|
I don't think it would affect performance beyond what rendering translucent faces in the right order to begin with would cost. |
There was a problem hiding this comment.
I wonder how this actually makes a difference because I think the order in which the quads are eventually rendered depends on the order of the enum and how it's then used in https://github.com/CaffeineMC/sodium-fabric/blob/dev/src/main/java/me/jellysquid/mods/sodium/client/render/chunk/DefaultChunkRenderer.java#L136
|
This PR does not make sense to me. The render order of geometry is determined by the renderer and is independent of the meshing process. Unless the slime/honey blocks for some reason just don't have their geometry tagged as sided for some reason (which would be a different bug) this PR should not fix anything. |
This results in the internal cube for slime and honey blocks being rendered more correctly.
it seems to render fine but does this negatively affect performance if those faces are done before axis-aligned ones?