Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BPM Detection #494

Draft
wants to merge 21 commits into
base: dev
Choose a base branch
from
Draft

BPM Detection #494

wants to merge 21 commits into from

Conversation

Caeden117
Copy link
Owner

@Caeden117 Caeden117 commented Nov 7, 2023

(Requires #493)

This PR implements a method of BPM detection to ChroMapper using AudioSync, a pure C# implementation of ArrowVortex's BPM detection algorithm.

Results should be pretty comparable to ArrowVortex, however the speed of AudioSync seems to be noticeably slower than in my basic benchmarking on .NET 7. I suspect this may be due to (i) Unity's Mono runtime or (ii) using Development/Debug mode for ChroMapper.

To-do List:

  • Implement AudioSync
  • Show more details about results in completion dropdown (Offset + Fitness?)
  • (more of an AudioSync thing) Add progress reporting to bpm detection
  • Apply detected BPM + offset to the map
  • Localize dialog boxes
  • Reference AudioSync via NuGet (NuGetForUnity was added in the 2021.3 PR) once AudioSync is published to NuGet

Base automatically changed from 2021.3 to dev January 26, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants