Add automatic updating of mesh bounding box when importing, view centering improvements #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CosmicDreamsOfCode
commented
Feb 9, 2024
CosmicDreamsOfCode
commented
- MeshSet AABB is now updated when importing a custom mesh
- You can now view the MeshSet AABB in the Mesh tab (mostly for debugging, its readonly, but nice to have ig)
- Slight refactor of viewport bb code to have an update method, this is used when centering the view so it will actually center to the correct point after a custom mesh is imported without reopening the asset
|
Realised last night that this may have issue with multi-section and lod models. Closing to investigate. |
|
i think i fixed it, should take the largest bbox out of all sections and lods, including unrenderable ones |
| vertexPositions.Add(new Vector3(position.X, position.Y, position.Z)); | ||
|
|
||
| } | ||
| boundingBox = AABBFromPoints(vertexPositions).Item2; |
There was a problem hiding this comment.
why not merge the bounding box here already?
|
|
||
| } | ||
| boundingBox = AABBFromPoints(vertexPositions).Item2; | ||
| //meshSet.BoundingBox = AABBFromPoints(vertexPositions).Item1; |
There was a problem hiding this comment.
also remove commented out stuff u added
| @@ -1653,6 +1673,7 @@ public void ImportFBX(string filename, MeshSet inMeshSet, EbxAsset asset, EbxAss | |||
| meshSet.ClearPartData(); | |||
| List<BoundingBox> partBbox = new List<BoundingBox>(); | |||
| List<LinearTransform> transforms = new List<LinearTransform>(); | |||
| AxisAlignedBox AABBToWrite = new AxisAlignedBox(); | |||
There was a problem hiding this comment.
why have a local variable here, just assign it to meshSet.BoundingBox directly
| retVal.min = min; | ||
| retVal.max = max; | ||
|
|
||
| return retVal; |
There was a problem hiding this comment.
u could also use just return new AxisAlignedBox() { min = new Vec3() { x = ... }, max = ... }, but doesnt really matter that much
|
other than that it looks, good to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.