Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NVIDIA GPUs detection #139

Merged
merged 9 commits into from
Oct 4, 2024
Merged

Fix NVIDIA GPUs detection #139

merged 9 commits into from
Oct 4, 2024

Conversation

ventureoo
Copy link
Member

No description provided.

Signed-off-by: Vasiliy Stelmachenok <[email protected]>
…s instead of device name patterns

Guarantees greater accuracy in profile selection

Signed-off-by: Vasiliy Stelmachenok <[email protected]>
Copy link
Member

@vnepogodin vnepogodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vnepogodin
Copy link
Member

we can land ids for nvidia-dkms after that PR actually

Since dumper adds the PCI ID as a key to the hash table to avoid
duplicates, we must sort the ID lists so that they are reproducible and
also for easy check against hwdata.

Signed-off-by: Vasiliy Stelmachenok <[email protected]>
…of pattern matching

Signed-off-by: Vasiliy Stelmachenok <[email protected]>
@ventureoo
Copy link
Member Author

we can land ids for nvidia-dkms after that PR actually

Done

Copy link
Member

@vnepogodin vnepogodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good-ich

@vnepogodin vnepogodin merged commit 8674d05 into master Oct 4, 2024
2 checks passed
@vnepogodin vnepogodin deleted the fix-nvidia-detection branch October 4, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants