Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to repo submodule from setup folder #169

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

OrionOth
Copy link
Member

@OrionOth OrionOth commented Oct 7, 2023

This begins the standardization process on the setup repository, rather than just having the folder as part of the parent repository as we did previously. This has the advantage of making it easier to migrate setup changes between different years/robots more easily, and this carries over to this repository as well with the seahawk_1 branch.

@mike-matera
Copy link
Member

mike-matera commented Oct 8, 2023

I don't think I want this right now because using a submodule complicates the process of adding and removing users from the Raspberry Pi. The current process is:

  1. Edit and commit the rov.yaml playbook.
  2. Push the change to the main branch of the 23 repo.
  3. Any user on the ROV can pull main and re-run make rov-install and the updates are made.

With the setup directory in a submodule the process becomes:

  1. Edit and commit the rov.yaml playbook in the setup repo.
  2. Push the change the the setup repo
  3. Make a "bump" commit to the main branch of the 23 repo to associate the new setup ref
  4. Push the change to the 23 repo
  5. Any user on the ROV can pull main and re-run make rov-install and the updates are made.

The submodule process is going to result in a bunch of senseless "bump setup version" commits in this repo. That's going to be annoying for everyone.

This begins the standardization process on the setup repository, rather
than just having the folder as part of the parent repository as we did
previously. This has the advantage of making it easier to migrate setup
changes between different years/robots more easily, and this carries
over to this repository as well with the `seahawk_1` branch.
@OrionOth
Copy link
Member Author

This commit was modified to remove the change on the h264_image_transport submodule and move it to #171 instead.

@OrionOth
Copy link
Member Author

This PR is on hold until we get CI (GitHub Actions) working.

@OrionOth OrionOth marked this pull request as draft October 13, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants