Revert "Also use fastForEach in working dialogs of PMGR & software up…

…date"

This reverts commit 0f6edab.

src/octoprint/plugins/pluginmanager/static/js/pluginmanager.js

@@ -788,9 +788,7 @@ $(function() {
         };
 
         self._scrollWorkingOutputToEnd = function() {
-            ko.bindingHandlers.fastForEach.FastForEach.animateFrame.call(window, function() {
-                self.workingOutput.scrollTop(self.workingOutput[0].scrollHeight - self.workingOutput.height());
-            });
+            self.workingOutput.scrollTop(self.workingOutput[0].scrollHeight - self.workingOutput.height());
         };
 
         self._getToggleCommand = function(data) {

src/octoprint/plugins/pluginmanager/static/less/pluginmanager.less

@@ -85,10 +85,6 @@ table {
 }
 
 #settings_plugin_pluginmanager_workingdialog_output {
-  span {
-    display: block;
-  }
-
   .message {
     font-weight: bold;
   }

src/octoprint/plugins/pluginmanager/templates/pluginmanager_settings.jinja2

@@ -108,7 +108,7 @@
         <h3 data-bind="text: workingTitle"></h3>
     </div>
     <div class="modal-body">
-        <pre id="settings_plugin_pluginmanager_workingdialog_output" class="terminal pre-scrollable" style="height: 170px" data-bind="fastForEach: loglines"><span data-bind="text: line, css: {stdout: stream == 'stdout', stderr: stream == 'stderr', call: stream == 'call', message: stream == 'message', error: stream == 'error'}"></span></pre>
+        <pre id="settings_plugin_pluginmanager_workingdialog_output" class="terminal pre-scrollable" style="height: 170px" data-bind="foreach: loglines"><span data-bind="text: line, css: {stdout: stream == 'stdout', stderr: stream == 'stderr', call: stream == 'call', message: stream == 'message', error: stream == 'error'}"></span><br></pre>
     </div>
     <div class="modal-footer">
         <button class="btn" data-dismiss="modal" data-bind="enable: !$root.working()" aria-hidden="true">{{ _('Close') }}</button>

src/octoprint/plugins/softwareupdate/static/js/softwareupdate.js

@@ -548,9 +548,7 @@ $(function() {
         };
 
         self._scrollWorkingOutputToEnd = function() {
-            ko.bindingHandlers.fastForEach.FastForEach.animateFrame.call(window, function() {
-                self.workingOutput.scrollTop(self.workingOutput[0].scrollHeight - self.workingOutput.height());
-            });
+            self.workingOutput.scrollTop(self.workingOutput[0].scrollHeight - self.workingOutput.height());
         };
 
         self.onBeforeWizardTabChange = function(next, current) {

src/octoprint/plugins/softwareupdate/static/less/softwareupdate.less

@@ -5,10 +5,6 @@ td.settings_plugin_softwareupdate_column_update {
 #settings_plugin_softwareupdate_workingdialog_output {
   font-size: 0.8em;
 
-  span {
-    display: block;
-  }
-
   .message {
     font-weight: bold;
   }

src/octoprint/plugins/softwareupdate/templates/softwareupdate_settings.jinja2

@@ -107,7 +107,7 @@
         <h3 data-bind="text: workingTitle"></h3>
     </div>
     <div class="modal-body">
-        <pre id="settings_plugin_softwareupdate_workingdialog_output" class="terminal pre-scrollable" style="height: 170px" data-bind="fastForEach: loglines"><span data-bind="text: line, css: {stdout: stream == 'stdout', stderr: stream == 'stderr', call: stream == 'call', message: stream == 'message'}"><br></pre>
+        <pre id="settings_plugin_softwareupdate_workingdialog_output" class="terminal pre-scrollable" style="height: 170px" data-bind="foreach: loglines"><span data-bind="text: line, css: {stdout: stream == 'stdout', stderr: stream == 'stderr', call: stream == 'call', message: stream == 'message'}"></span><br></pre>
     </div>
     <div class="modal-footer">
         <button class="btn" data-dismiss="modal" data-bind="enable: !$root.working()" aria-hidden="true">{{ _('Close') }}</button>