Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sort talks page #717

Merged
merged 8 commits into from
Aug 20, 2024
Merged

Feature/sort talks page #717

merged 8 commits into from
Aug 20, 2024

Conversation

drnlm
Copy link
Member

@drnlm drnlm commented Aug 19, 2024

This adds support for sorting the talks list by track, language or title.

We add links to the table headers to switch sorting.

Sorting is currently global, although it can be triggered on any of the tables created by using multiple talk types, but I don't think the complexity of sorting within a type only is worthwhile.

Closes #710

Copy link
Member

@stefanor stefanor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wafer/talks/views.py Outdated Show resolved Hide resolved
Comment on lines +201 to +203
self.assertGreater(pos_talk_a, pos_talk_b)
self.assertGreater(pos_talk_b, pos_talk_c)
self.assertGreater(pos_talk_c, pos_talk_d)
Copy link
Member

@hodgestar hodgestar Aug 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to make this assert closer to self.assertTrue(D < C < B < A)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That construction loses information about which specific item was out of order if the test fails.

Appy feedback from PR

Co-authored-by: Stefano Rivera <[email protected]>
@drnlm drnlm merged commit 868ad0e into CTPUG:master Aug 20, 2024
43 checks passed
@drnlm drnlm deleted the feature/sort_talks_page branch October 5, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show track on talk list
3 participants