-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add challenge mirror, verify, format functionality #134
Conversation
Also I think we'll want to add |
- pass files_directory_name - fix files key not found - fix tests on 3.8
Hi there, I no longer have time to land this PR, but I have some additional changes on my fork you may want to port over after a lot of testing with my college club. Good luck landing this! |
I like the choice of subcommands here. In terms of the deploy I think if we can mirror just the connection_info it would be best. |
@MilyMilo This seems good to go. Is this still WIP or ready to merge? |
Yeah let's add the mirror after sync, I'll do that now. |
- add connection_info to the local challenge after deployment - add format command to format challenge.yml files - add more documentation
Okay so some more changes:
|
Adds
ctf challenge mirror <challenge>
andctf challenge verify <challenge>
adapted from #106Originally, this functionality was called
pull
andverify
- however,push
is already used to push challenge changes to the git repository. I thinkmirror
is a better name, as ctfcli will attempt to mirror / copy the remote state from ctfd. This waypull
stays in its current git-like form, for git-related operations.More additions:
files_directory_name
(defaulting todist
) to specify where ctfcli should download the files, relative to challenge.ymlctf challenge verify
will exit with status code 2 if the verification was successful, but some challenges are out of sync.Thanks to @reteps for the initial contribution!
Closes: #101 #106