Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap 403 error messaging for legibility #76

Conversation

cgoecknerwald
Copy link
Contributor

@cgoecknerwald cgoecknerwald commented Apr 6, 2024

image image

@ColdHeat
Copy link
Member

ColdHeat commented Apr 6, 2024

Can you do this for all error templates? Essentially change the order and add the error code. Also the {% trans %} blocks should be on the static string (i.e. {% trans %}(403 Forbidden){% endtrans %}).

I also think you can remove the HTML comment. I feel like I woudn't do the parens around the error code but it's up to you.

@ColdHeat ColdHeat merged commit 79cb6e5 into CTFd:main Apr 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants