Fix navbar links alignment #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When I test this change I don't see as big of an offset as in your screenshot but if this is useful to you and there doesn't seem to be a change for the current use case it's probably okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spanandielements shouldn't be displayed as blocks in Bootstrap, but as inline elements.Displaying them as block can cause some misalignment when a CTF admin overrides the navbar template to add other buttons without tooltips.
This pull request proposes to switch to inline elements to make the navbar less ugly to override.
Demo with left button after patch and right button before patch:
