Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #31: Contact page added. #33

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix #31: Contact page added. #33

wants to merge 2 commits into from

Conversation

Shivangi-ch
Copy link
Contributor

Explanation

Fixes #31: Added the contact page.

Type of Change:

  • Code
  • Quality Assurance
  • User Interface
  • Outreach

Checklist

  • The PR title starts with "Fix #bugnum: "followed by a short, clear summary of the changes. ( If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...")
  • [x ] The PR explanation includes the words "Fixes #bugnum: ..." ( or "Fixes part of #bugnum" if the PR only partially fixes an issue ).
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR does not break any part of the existing code.
  • The PR creator have carefully read & adhere to the contributing guidelines of the project.
  • The PR is raised for an issue that has been assigned to you.
  • The PR is made to the branch that's called "develop".
  • [x]The PR is raised from a branch that is up-to-date with "develop".
    cswala_contactpage

@Shivangi-ch
Copy link
Contributor Author

@5tupidbrain please review!

@CSwala CSwala deleted a comment from vercel bot May 10, 2021
Copy link
Contributor

@saranshhardaha saranshhardaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes

- Make the animation start small
- Add the socials on right side below mail image.! and align them properly
- Show social and mail on mobile view also

@Shivangi-ch
Copy link
Contributor Author

@5tupidbrain I have made the changes .

@Shivangi-ch
Copy link
Contributor Author

Hey @5tupidbrain Please Review!

Copy link
Contributor

@saranshhardaha saranshhardaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve this issue

image

  • Discord Icon is not inside "a" tag.

Changes

- Add padding and margin on top,
- Show mail Illustration on top Socials on bottom
- Center the elements.!
- Set input to use full width of the container [Don't set to use full screen width]
- Set fixed size for button

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Contact Page 📧 [FrontEnd]
2 participants