-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a C++ parser for our EVENT logs #171
Open
Quincunx271
wants to merge
17
commits into
CSUS-LLVM:master
Choose a base branch
from
Quincunx271:feature/c++logparsing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP - need to: - Benchmark name parsing - File name parsing - RawLog parsing (lazy; we don't want to hold onto the memory unless we need it) - Integration into the Python code
Getting close
Previously, accessing a single element required creating the entire array. Adding these reference types solves that issue.
Stray null bytes
absl::flat_hash_{set,map} are called "swiss tables", and they provide a small perf win for us.
Manually triggered script which uploads the artifact.
Quincunx271
force-pushed
the
feature/c++logparsing
branch
from
August 24, 2021 23:13
a8642dc
to
a61e637
Compare
This way, by placing all of these modules in a directory on the LD_LIBRARY_PATH, g++-11, libtbb, etc. do not need to be installed to use the Python module, as the needed libraries are bundled here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benefits:
Drawbacks: