Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support newer LLVM versions #170

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Quincunx271
Copy link
Member

@Quincunx271 Quincunx271 commented Aug 20, 2021

Supports up to LLVM 13 (without spilling info).

  • llvm::make_unique -> std::make_unique.
  • Register, referring to llvm::opt_sched::Register, is now explicit
    in most places.
  • llvm::StringRef's conversion to std::string is now explicit. This
    exposes some inefficiencies with what we're doing.

Supports up to LLVM 13.
 - `llvm::make_unique` -> `std::make_unique`.
 - `Register`, referring to `llvm::opt_sched::Register`, is now explicit
   in most places.
 - `llvm::StringRef`'s conversion to `std::string` is now explicit. This
   exposes some inefficiencies with what we're doing.
@Quincunx271 Quincunx271 force-pushed the support-newer-llvm branch 3 times, most recently from de3c685 to 7270b65 Compare August 20, 2021 23:02
@Quincunx271 Quincunx271 force-pushed the support-newer-llvm branch 4 times, most recently from 16ea595 to 40426cd Compare August 23, 2021 20:53
@Quincunx271
Copy link
Member Author

Should probably just drop support for LLVM 6.0. The issue is that somehow -std=c++11 is passed even though everything is specifying C++14. Given that we're all using LLVM 7.1+ (or at least we should be), we should drop LLVM 6. TBH we should actually just come up with the highest minimum LLVM version we want to support (e.g. maybe LLVM 9 works).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant