Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalizing the SoarCodelet as a PlanningCodelet #28

Merged
merged 2 commits into from
Apr 5, 2021
Merged

Conversation

andre-paraense
Copy link

@andre-paraense andre-paraense commented Dec 22, 2020

Why was it necessary?

Generalization of the SoarCodelet as a PlanningCodelet

How was it done?

An interface called IPlanningCodelet was created to generalize the use of SoarCodelet in mounting the MECA mind. A few bits and pieces of refactoring was done here and there.

Now, other Planning Codelets can be created implementing the same interface to be used replacing the SoarCodelet as well.

How to test?

Run ./gradlew clean build.

Alternatively, you can test this build in one of your applications importing it in your build.gradle as:

implementation 'com.github.CST-Group:meca:45b33010547fedbed5508ac4828aa81d2684587f'

@codeclimate
Copy link

codeclimate bot commented Dec 22, 2020

Code Climate has analyzed commit 8a933b4 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2
Clarity 2

The test coverage on the diff in this pull request is 74.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 67.0% (5.6% change).

View more on Code Climate.

Copy link
Member

@rgudwin rgudwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked this version with TROCA and it worked without any problem.

@rgudwin rgudwin merged commit bd5e50b into master Apr 5, 2021
@rgudwin rgudwin deleted the issue-27 branch April 5, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants