Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplication issue on adding child to RTDB #298

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MB2M
Copy link

@MB2M MB2M commented Mar 24, 2023

Listeners on "value" event were not remove on unmount + Unsubscribe functions were not called properly.

@kutsan
Copy link

kutsan commented Mar 25, 2023

I just tested this PR locally and it's working. Thanks!

@revelcw
Copy link

revelcw commented Oct 15, 2023

+1 This fixes the issue with React's StrictMode rerunning useEffects twice. lgtm

@yamcodes
Copy link

yamcodes commented Nov 29, 2023

This needs to be merged. As things stand this library is unusable on an updated environment (React v18). Internally, we're forced to use a fork just to be able to use this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants