-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure HealthKit and notification authorizations #6
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
==========================================
+ Coverage 38.12% 40.90% +2.79%
==========================================
Files 31 30 -1
Lines 976 961 -15
==========================================
+ Hits 372 393 +21
+ Misses 604 568 -36
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dhruvna1k,
Thank you for the PR and the improvements. It's a good first version that needs some more work to be merged.
First: Please update your GitHub profile to show your full name and a profile picture!
The PR in its current state is a bit incomplete: It does not update the text in the HealthKit onboarding flow to change the text to the needs of your application. Please complete this before re-requesting a review.
I have noticed that your SwiftLint checks are failing due to some changes in the code that do not conform to the SwiftLint style guide. Please be sure to address them. You can learn more about each rule, including passing and failing examples, in the Swift Documentation.
In addition, your PR description does not follow the PR template that we introduced in the class, and that is provided by default: https://github.com/CS342/.github/blob/main/.github/pull_request_template.md.
Please follow the following template in your PR description and add a good description of your PR by editing the PR description on the PR page.
Please also add a more descriptive and clear title focusing on the added functionality rather than the assignment task.
Please also read through the "Keeping your pull request in sync with the base branch" documentation to ensure that your branch is up to date with the main branch before you merge it into the main branch.
Please re-request a review once you have implemented all the requested changes.
Removing notifications view file since it is unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dhruvna1k,
Thank you for the improvements in the PR!
Thank you for adding the profile picture: Please also update your GitHub profile to show your full name.
Please also read through the "Keeping your pull request in sync with the base branch" documentation to ensure that your branch is up to date with the main branch before you merge it into the main branch.
Please re-request a review once you have implemented all the requested changes.
Removing notifications view file since it is unused
33491c8
to
505b7e3
Compare
…into feature/configureHK+notifications
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhruvna1k We are getting closer to a finished PR.
Please be sure that you run and test the application in Xcode and that you resolve all the conversations completely by addressing them in the code before re-requesting a review.
Once the last conversations are resolved please re-request a review 👍
Thanks for the reminder. I think I forgot to build the project before commiting/pushing the changes last time. Have made the proper changes and remembered to build this time before committing/pushing. Let me know if this doesn't work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhruvna1k Thank you for the improvements and fixing the last issues! The PR looks great to me and good job with improving it step by step.
We hope you learned some new stills in the PR and are looking forward to a great project this quarter!
Configure HealthKit and notification authorizations
♻️ Current situation & Problem
The data being collected from HealthKit in the TemplateApplication is not configured for our purposes. There is also pre-existing notification permissions, which we do not need.
📚 Documentation
Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
No additional documentation needed, just a configuration of the code
✅ Testing
No additional testing needed, code and previews compile
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: