Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten Time Index #50

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Flatten Time Index #50

merged 2 commits into from
Mar 29, 2024

Conversation

mjoerke
Copy link
Collaborator

@mjoerke mjoerke commented Mar 28, 2024

Flatten Time Index

♻️ Current situation & Problem

Our current time indexing functionality writes time index entries as nested fields in Firebase, e.g., "time.day.start". For some reason, Firebase fetching (both in Swift and Python) does not play nicely with these nested indices. For example, querying collection.where("time.day.start", "<=", 10) returns an empty list. Renaming this field to "dayStart" and avoiding nested fields fixes this issue.

⚙️ Release Notes

  • Modified Date+ConstructTimeIndex.swift to remove nested indices

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 27.30%. Comparing base (18e0bc8) to head (32a0bb8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   26.58%   27.30%   +0.73%     
==========================================
  Files          53       53              
  Lines        1942     1942              
==========================================
+ Hits          516      530      +14     
+ Misses       1426     1412      -14     
Files Coverage Δ
Prisma/Standard/PrismaStandard+HealthKit.swift 0.00% <0.00%> (ø)
Prisma/Helper/Date+ConstructTimeIndex.swift 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18e0bc8...32a0bb8. Read the comment docs.

@mjoerke mjoerke merged commit 8c6f4d5 into main Mar 29, 2024
7 checks passed
@mjoerke mjoerke deleted the fix/flatten-timeindex branch March 29, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant