Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flatten Time Index
♻️ Current situation & Problem
Our current time indexing functionality writes time index entries as nested fields in Firebase, e.g., "time.day.start". For some reason, Firebase fetching (both in Swift and Python) does not play nicely with these nested indices. For example, querying
collection.where("time.day.start", "<=", 10)
returns an empty list. Renaming this field to "dayStart" and avoiding nested fields fixes this issue.⚙️ Release Notes
Date+ConstructTimeIndex.swift
to remove nested indices📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: